[Ruediger Pluem] > How about letting these users simply turn off sendfile via > > EnableSendfile Off
Uh, first, because I didn't know Apache had that option. Second ... well, I still would have written the patch. If there's an easy way to save sysadmins some troubleshooting and Googling and editing a config file, I'm happy to do that. I guess I have a bias toward trying to make the system as painless as possible for the sysadmins and users, as opposed to making it as painless as possible for the developers. At least as long as it's easy and straighforward, as this patch was. The complexity of the 90-line patch, by the way, should be weighed against the complexity of the smarter autoconf test Joe proposed. And part of my patch is refactoring the function into smaller pieces, which (at least IMO) is also a net win, despite added lines of source.
signature.asc
Description: Digital signature
