On Fri, May 11, 2007 at 01:39:15PM +1000, Bojan Smojver wrote:
> At present, we have in this function:
>
> if (thefile->buffered) {
> flush
> adjust various buffer offsets
> }
>
> If two threads do this for the same file (i.e. apr_file_t*), offsets may
> end up screwed. Shouldn't we surround this with lock/unlock, like we do
> in apr_file_write()?
Yes, that looks necessary.
> PS. Also, I think we can do this only for HAVE_WRITEV as in the other
> case apr_file_write() will take care of the whole thing (i.e. that
> function already has a buffered path).
Yup. BTW can you add CHANGES entries (on both 1.2.x and 0.9.x branches)
listing the PR 40963 fix?
joe
