Joe Orton wrote:
On Sun, Oct 14, 2007 at 11:07:43PM -0000, William Rowe wrote:
Author: wrowe
Date: Sun Oct 14 16:07:43 2007
New Revision: 584634
URL: http://svn.apache.org/viewvc?rev=584634&view=rev
Log:
recvfrom() failed on most platforms with a sockaddr only
large enough to hold an ipv6 address. Big shock.
If that fails it's a bug in the apr_socket_recvfrom() implementation.
There is no reason that function should fail if the *from argument
happened to previously be representing a socket address of a different
family to the socket from which a block is being read - it's an output
parameter for the function.
If we know for a fact that the sockaddr is allocated of sufficient size,
I'm fine with backing out this change and solving the underlying function.
Contrawise I suppose we aught to be writing over an ipv6 sockaddr with
the ipv4 test, eh?
Bill
