[EMAIL PROTECTED] wrote:
> Author: bojan
> Date: Sun Nov 11 23:46:40 2007
> New Revision: 594037
>
[..]
> #if APR_HAS_THREADS
> static apr_thread_mutex_t* mutex = NULL;
> -apr_status_t apr_dbd_mutex_lock()
> +APU_DECLARE(apr_status_t) apr_dbd_mutex_lock()
> {
> return apr_thread_mutex_lock(mutex);
> }
> -apr_status_t apr_dbd_mutex_unlock()
> +APU_DECLARE(apr_status_t) apr_dbd_mutex_unlock()
> {
> return apr_thread_mutex_unlock(mutex);
> }
Missing for the #else case.
>
> /* Export mutex lock/unlock for drivers that need it */
> -apr_status_t apr_dbd_mutex_lock(void);
> -apr_status_t apr_dbd_mutex_unlock(void);
> +APU_DECLARE(apr_status_t) apr_dbd_mutex_lock(void);
> +APU_DECLARE(apr_status_t) apr_dbd_mutex_unlock(void);
>
It's the functions supposed to be publicly used? If yes, you should
export then properly (apr_dbd.h). If not, it would be better to extend
apr_dbd_t with lock and unlock methods which can back point to private
functions.
Regards,
--
Davi Arnaut
