OK. I think I've incorporated most if not all of the feedback and I've raised an issue here:
http://issues.apache.org/bugzilla/show_bug.cgi?id=44127 Here is a second round of patches based on feedback from the list. Changes: * Moved headers out of apr_file_info.h into apr_file_xattr.h * Change interface from const char* filename to use apr_file_t *file * Removed APR_XATTR_NOFOLLOW from flags (in line with change to apr_file_t* based interface) * Changed flags apr_int32_t from to apr_uint32_t * Updated tests and sample client apxattr to API revisions * Clarified apr_get_xattr docs on pool allocation of void **value * Moved from file_io/unix/xattr_(darwin|linux|freebsd|solaris).c to file_io/unix/xattr/(darwin|linux|freebsd|solaris).c * Added code to escape and unescape '/' characters in Solaris subfile (attribute) names. Also added special char test cases. * Added APR_ENOTIMPL stubs for netware, os2, win32 and unsupported unix * Added --disable-xattr configure flag (enabled by default if detected) Headers, build infrastructure and test cases: http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-headers.patch http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-build.patch http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-tests.patch Mac OS X, FreeBSD, Linux and Solaris implementations plus ENOTIMPL stubs for unsupported platforms http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-impl-stubs.patch http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-impl-darwin.patch http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-impl-freebsd.patch http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-impl-linux.patch http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-impl-solaris.patch All-in-one patch (applies cleanly to trunk) http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apr-xattr-all.patch apxattr - Utility to view/modify extended attributes on files http://oss.metaparadigm.com/apache-privsep/2.3.0-dev/xattr-patches/apxattr.c
