On Wed, May 21, 2008 at 09:49:37AM +1000, Bojan Smojver wrote: > On Tue, 2008-05-20 at 19:34 -0400, Bob Rossi wrote: > > --- apr-util-1.3.x-2008-05-19-svn/build/dbd.m4 Tue May 20 17:15:38 2008 > > +++ apr-util-1.3.x-2008-05-19-svn.changed/build/dbd.m4 Tue May 20 19:18:23 > > 2008 > > @@ -53,7 +53,8 @@ > > AC_PATH_PROG([PGSQL_CONFIG],[pg_config],,[$withval/bin]) > > if test "x$PGSQL_CONFIG" != 'x'; then > > pgsql_CPPFLAGS="-I`$PGSQL_CONFIG --includedir`" > > - pgsql_LDFLAGS="-L`$PGSQL_CONFIG --libdir` `$PGSQL_CONFIG --libs`" > > + pgsql_LDFLAGS="-L`$PGSQL_CONFIG --libdir`" > > + pgsql_LDFLAGS="$pgsql_LDFLAGS `$PGSQL_CONFIG --libs`" > > > > There are a couple places the above is done, I only had to change it > > here. If this is done in multiple steps, it avoids a ^A inbetween the > > --libdir and --libs command. I don't know where the ^A comes from, but > > when the lines are separated, it goes away. Any ideas? > > Must be some Windows-ism that I'm unaware of. Having two lines is not a > problem though. > > > else > > pgsql_CPPFLAGS="-I$withval/include" > > pgsql_LDFLAGS="-L$withval/lib " > > @@ -63,9 +64,9 @@ > > APR_ADDTO(LDFLAGS, [$pgsql_LDFLAGS]) > > > > I'm not quiet sure you want to do the above. Do you really want apr to > > depend on all these libraries? > > We revert that back to old_ldflags a bit further down in the code. So, > not an issue.
Hi Bojan, I noticed you changed everything but the AC_CHECK_LIB, do you believe that is unnecessary, or are you thinking about it? Thanks, Bob Rossi
