On Fri, 2008-08-08 at 07:46 +1000, Bojan Smojver wrote:

> Patch is attached.

Just got feedback from the original bug reporter (Rainer Jung) and the
attached patch is incorrect. So, here is the patch submitted with the
bug report that fixes the issue on Solaris.

-- 
Bojan
--- configure.in-orig	2008-07-31 13:09:38.000000000 +0200
+++ configure.in	2008-07-31 13:17:33.000000000 +0200
@@ -1345,6 +1345,20 @@
     socklen_t_value="int"
 fi
 
+APR_CHECK_SIZEOF_EXTENDED([#include <sys/types.h>], pid_t, 8)
+
+if test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_short"; then
+    pid_t_fmt='#define APR_PID_T_FMT "hd"'
+elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_int"; then
+    pid_t_fmt='#define APR_PID_T_FMT "d"'
+elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long"; then
+    pid_t_fmt='#define APR_PID_T_FMT "ld"'
+elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long_long"; then
+    pid_t_fmt='#define APR_PID_T_FMT APR_INT64_T_FMT'
+else
+    pid_t_fmt='#error Can not determine the proper size for pid_t'
+fi
+
 # Basically, we have tried to figure out the correct format strings
 # for APR types which vary between platforms, but we don't always get
 # it right.
@@ -1360,9 +1374,9 @@
        ;;
    *-solaris*)
        if test "$ac_cv_sizeof_long" = "8"; then
-         pid_t_fmt="d"
+         pid_t_fmt='#define APR_PID_T_FMT "d"'
        else
-         pid_t_fmt="ld"
+         pid_t_fmt='#define APR_PID_T_FMT "ld"'
        fi
        ;;
    *aix4*|*aix5*)
@@ -1496,20 +1510,6 @@
 fi
 AC_MSG_NOTICE([using $ino_t_value for ino_t])
 
-APR_CHECK_SIZEOF_EXTENDED([#include <sys/types.h>], pid_t, 8)
-
-if test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_short"; then
-    pid_t_fmt='#define APR_PID_T_FMT "hd"'
-elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_int"; then
-    pid_t_fmt='#define APR_PID_T_FMT "d"'
-elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long"; then
-    pid_t_fmt='#define APR_PID_T_FMT "ld"'
-elif test "$ac_cv_sizeof_pid_t" = "$ac_cv_sizeof_long_long"; then
-    pid_t_fmt='#define APR_PID_T_FMT APR_INT64_T_FMT'
-else
-    pid_t_fmt='#error Can not determine the proper size for pid_t'
-fi
-
 # Checks for endianness
 AC_C_BIGENDIAN
 if test $ac_cv_c_bigendian = yes; then

Reply via email to