On 10/17/2009 11:58 PM, Ryan Phillips wrote: > On Sat, Oct 17, 2009 at 2:40 AM, Ruediger Pluem <[email protected]> wrote: >> >> On 10/17/2009 05:50 AM, Ryan Phillips wrote: >>> On Wed, Oct 14, 2009 at 12:02 PM, Neil Conway <[email protected]> wrote: >>>> "./tests/testall testpoll" segfaults for me consistently on OSX 10.6.1 >>>> with the latest code from the 1.4-stable branch (64-bit APR library). >>>> gdb info: >>>> >>>> #0 0x000000010000e9b7 in send0_pollset (tc=0x7fff5fbfef80, data=0x0) >>>> at testpoll.c:389 >>>> 389 ABTS_PTR_EQUAL(tc, s[0], descs[0].desc.s); >>>> (gdb) bt >>>> #0 0x000000010000e9b7 in send0_pollset (tc=0x7fff5fbfef80, data=0x0) >>>> at testpoll.c:389 >>>> #1 0x0000000100001456 in abts_run_test (ts=0x100200190, f=0x10000e925 >>>> <send0_pollset>, value=0x0) at abts.c:168 >>>> #2 0x000000010000f713 in testpoll (suite=0x100200190) at testpoll.c:685 >>>> #3 0x0000000100001e35 in main (argc=2, argv=0x7fff5fbff020) at abts.c:424 >>>> (gdb) p descs >>>> $1 = (const apr_pollfd_t *) 0x0 >>>> (gdb) p s[0] >>>> $2 = (apr_socket_t *) 0x100804240 >> What is the value of num? >> >>>> (gdb) l >>>> 384 rv = apr_pollset_poll(pollset, 0, &num, &descs); >>>> 385 ABTS_INT_EQUAL(tc, APR_SUCCESS, rv); >>>> 386 ABTS_INT_EQUAL(tc, 1, num); >>>> 387 ABTS_PTR_NOTNULL(tc, descs); >>>> 388 >>>> 389 ABTS_PTR_EQUAL(tc, s[0], descs[0].desc.s); >>>> 390 ABTS_PTR_EQUAL(tc, s[0], descs[0].client_data); >>>> 391 } >>>> 392 >>>> 393 static void recv0_pollset(abts_case *tc, void *data) >>>> >> Regards >> >> Rüdiger >> > > Num on the freebsd machine is 0. >
Thanks for that. I guess we have two problems here: 1. The crash: We simply should not execute the lines 389 and 390 if descs is NULL. Similar situations occur in various other parts of the test suite. We use ABTS_PTR_NOTNULL and continue afterwards and continue to use the pointer that failed ABTS_PTR_NOTNULL. So does this need to be fixed everywhere where this occurs? I guess a crash of the test program just because ABTS_PTR_NOTNULL failed is not acceptable. 2. If descs is NULL it means that the test failed as we have the ABTS_PTR_NOTNULL test in line 387. The question is: Why does this test fail? Regards Rüdiger
