On Thu, Jan 21, 2010 at 3:46 PM, Graham Leggett <[email protected]> wrote:
> You move them back to the source module where they originated? :)
>
> I see some refactoring was done, perhaps in hindsight this refactoring
> should be re-looked at.

I don't see why: apr_pollset_wakeup() already used a "private"
function that was called from several different source files
(apr_pollset_drain_wakeup_pipe()). The apr_pollcb_wakeup() patch
simply adds two more APR-internal functions, and moves the definition
of all 3 functions to a separate source file.

Neil

Reply via email to