On Tuesday, February 16, 2010, Mladen Turk <[email protected]> wrote:
> On 02/16/2010 06:07 PM, [email protected] wrote:
>
> Log:
> Make sure we don't leak file descriptors.
>
>           if (new_m->shmkey == (key_t)-1) {
> +            apr_file_close(file);
>               return errno;
>           }
>
>
> File will be closed when the pool gets destroyed.
> Closing here has little advantages cause the pool
> memory will rise over time so you cannot be sure
> the provided pool won't get dirty if open fails.

Makes sense here


-- 
Born in Roswell... married an alien...

Reply via email to