On Mon, Apr 28, 2014 at 11:03 AM, Jim Jagielski <[email protected]> wrote:
> BTW: What about: > > http://svn.apache.org/viewvc?view=revision&revision=745763 > > A major concern is that the layout/size of the apr_sockaddr_t in 1.x can't change since it isn't an opaque type: >From 745763: @@ -245,6 +268,10 @@ * dependent on whether APR_HAVE_IPV6 is defined. */ struct sockaddr_storage sas; #endif +#if APR_HAVE_SOCKADDR_UN + /** Unix domain socket sockaddr structure */ + struct sockaddr_un unx; +#endif } sa; }; Also, I recall spending a bit (but not enough) time looking at management of AF_UNIX socket addresses in the past, and it seemed like APR could really help manage the storage (beyond simply struct sockaddr_un) to allow the largest possible socket paths. (I think the problem at the time was that socket paths had to be explicitly configured out of /path/to/httpd/logs/mod_foo/XXX more often than you'd like because of running out of space in sun_path before hitting a filesystem limitation.) But that's more clearly a 2.0 issue. > On Apr 28, 2014, at 7:33 AM, Yann Ylavic <[email protected]> wrote: > > > Hello, > > > > I would be nice to have these in 1.6.x too. > > > > Regards, > > Yann. > > > > On Sat, Jan 25, 2014 at 6:47 PM, Jim Jagielski <[email protected]> wrote: > >> Any reason why we've never pulled > >> > >> http://svn.apache.org/viewvc?view=revision&revision=741869 > >> http://svn.apache.org/viewvc?view=revision&revision=741862 > >> > >> into apr-1.5 ? > >> > >> If these look useful, and adding them doesn't break the ABI, > >> I'm willing to do the work required to backport. > >> > >> FWIW: They are almost 5 years old! > > > > -- Born in Roswell... married an alien... http://emptyhammock.com/ http://edjective.org/
