Redirecting this simply to APR... On Mon, Oct 16, 2017 at 11:49 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > I raised the question of whether the OS/X changes introduced and backported > in APR are still necessary or desired, or if they should be backed out, and > whether this patch, munged for APR_ macros, is needed for apr 1.6.3 tag? > > Yann suggests; > > On Oct 16, 2017 11:31, "Yann Ylavic" <ylavic....@gmail.com> wrote: > > I didn't look at the APR issue still, same one? > At first glance, APR_ADD_GCC_CFLAG doesn't exist, neither does > --maintainer-mode try to set -Werror. > Or am I missing something?
Or am I? Pinging Jim as he constructed the OS/X fix to both APR and httpd. Perhaps this was out of caution, perhaps this was a specific apr/apr-util build failure on xcode 9? Jim, could you elaborate? > Also, do we want this for APR-1.6 and 1.7? IIRC for instance our use > of readdir[_r]() might trigger warnings with latest linuxes, or was > this addressed? AIUI, we did not change readdir to remove the useless _r() construct, although it had a bit of activity on the dev@ list. That might not be the only part that would break adding -Werror, but fixing it finally would be good. I don't believe changing the build flags compromises 1.6, except so far as we don't thoroughly test. We have maintainers of all platforms for svn, httpd, tomcat and log4cxx and so on here to double-check the state of apr 1.6.3-dev... but that takes some cycles and any major flag changes should probably happen after the 1.6.3 tag, with lots of time for review of 1.6.4-dev branch. I don't have a problem adding -Werror and resolving the apr and apr-util (inherited) toggle. I'm of the thought that maintainer mode should not error out, but emit all of the bad constructs as warnings, and the more permissive 'typical' build would omit the extra warnings, but -Werror - since the devs can read error output. Typical consumers/deployments don't expect to need to. > + *) configure.in: Fix maintainer mode with GCC/Clang. > + Setting -Wstrict-prototypes in combination with -Werror leads to > compiler > + errors during configure checks (autoconf generates incomplete > prototypes). > + As suggested by Joe, add --maintainer/debugger-mode's CFLAGS in > + NOTEST_CFLAGS to avoid interractions with autoconf's AC_LANG_PROGRAM. > + APACHE_ADD_GCC_CFLAG now also forces -Wno-strict-prototypes for -Werror > + to work despite AC_LANG_PROGRAM generating this warning by itself. > + trunk patch: http://svn.apache.org/r1812263 > + http://svn.apache.org/r1812301 > + 2.4.x patch: svn merge -c 1812263,1812301 ^/httpd/httpd/trunk . > + +1: ylavic
