On 04.11.2017 23:49, Yann Ylavic wrote: > On Sat, Nov 4, 2017 at 11:29 PM, Branko Čibej <br...@apache.org> wrote: >> On 04.11.2017 23:03, build...@apache.org wrote: >>> The Buildbot has detected a new failure on builder apr-x64-macosx-trunk >>> while building . Full details are available at: >>> https://ci.apache.org/builders/apr-x64-macosx-trunk/builds/49 > [] >> This looks like fallout from r1814326. This part is clearly wrong: >> >> http://svn.apache.org/viewvc/apr/apr/trunk/misc/unix/rand.c?r1=1814326&r2=1814325&pathrev=1814326 >> >> >> The presence of the <sys/random.h> header does *not* mean that you can >> use getrandom(); you always have to check HAVE_GETRANDOM explicitly. The >> correct check is probably this: >> >> #if defined(HAVE_SYS_RANDOM_H) && HAVE_GETRANDOM >> #include <sys/random.h> >> #define USE_GETRANDOM >> #else ... > Thanks for the review! > > Fixed in r1814329 (hopefully).
You beat me to it, I was just testing a similar solution locally when your commit came in. >> Interestingly enough, if this check were correct, APR would choose >> arc4random_buf() on OSX 10.12, i.e., it would make use of stsp's patch. > I did not mean to force everyone to use latest Linux, I swear :) Yeah, right, not as far as we know ... :) -- Brane
