On Tue, Nov 28, 2017 at 12:22:27AM +0100, Yann Ylavic wrote: > On Mon, Nov 27, 2017 at 5:54 PM, Joe Orton <jor...@redhat.com> wrote: > > Version #2. > > > > Adds both apr_sockaddr_zone_set() and apr_sockaddr_zone_get() to set and > > retrieve the zone id/name. > > Looks good to me.
Thanks Yann for the review! Committed: http://svn.apache.org/viewvc?view=revision&revision=1816527 I hope the Win32 bit doesn't break. > > Also now changes apr_sockaddr_equal() to compare different scopes as not > > equal, which I think is the only sensible way to do it, although that > > function is a bit odd in ignoring port differences already. > > Yeah, I was beaten by this already, we should probably provide > apr_sockaddr_port_equal() or something like this. Bikeshedding, maybe apr_sockaddr_cmp() which compares everything properly? Then again, even comparing the port, ->hostname and ->servname are still ignored! Regards, Joe
