Am 02.01.2018 um 19:11 schrieb Eric Covener:
On Tue, Jan 2, 2018 at 12:51 PM, Eric Covener <cove...@gmail.com> wrote:
On Tue, Jan 2, 2018 at 12:37 PM, Yann Ylavic <ylavic....@gmail.com> wrote:
On Tue, Jan 2, 2018 at 6:28 PM, <yla...@apache.org> wrote:
Author: ylavic
Date: Tue Jan 2 17:28:53 2018
New Revision: 1819858
URL: http://svn.apache.org/viewvc?rev=1819858&view=rev
Log:
poll, port: re-add the wakeup pipe to the pollset after it triggered.
Just like user fds (file, socket), otherwise it's one shot only (PR-61786).
I can't really compile/test this (no Solaris at hand), reasoning based
on code inspection...
Corresponding test committed in r1819857.
May someone with the {hard,soft}ware test at r1819857 and then at
r1819858 (this commit) to see if it makes a difference?
I expect "testpoll" to wait indefinitely before at r1819857, and work
as usual at r1819858...
Thanks!
I am testing this now on Solaris/x64 and will report back. Thanks for
the great work on event!
testpoll hangs at 1819857 and works at 1819861 (latest)
I did a check on Solaris 10 Sparc. Looks good as well:
- r1819856 (without the additional check and without the fix): no hang
in testpoll
- r1819857 (with the additional check but still without the fix): hangs
in testpoll in pollset_wakeup, more precisely in the new for loop in
iteration 2 of 2 and there in the call to apr_pollset_wakeup().
- r1819858 (with the additional check and with the fix): no hang in testpoll
- r1819902 (head of trunk): no hang in testpoll
Thanks for finding and fixing this!
Happy new year,
Rainer
