> On 25 Aug 2018, at 00:39, Yann Ylavic <ylavic....@gmail.com> wrote:
>
> On Fri, Aug 24, 2018 at 11:13 PM <n...@apache.org> wrote:
>>
>> - if ((*num = j)) { /* any event besides wakeup pipe? */
>> + if (nres > 0) { /* any event besides wakeup pipe? */
>> + *num = nres;
>> rv = APR_SUCCESS;
>
> Shouldn't we set *num = 0 still?
It already is (at the top). But yes, that could be further rationalised.
I basically fixed what caused me to take twice as long as it should
have done to review it (though obviously the ugliness was older
than your fix I was reviewing).
> Btw, this commit probably needs to go to trunk too.
Agreed. And 1.7. Will do - unless you get there first.
--
Nick Kew
