On Wed, Mar 13, 2019 at 6:10 PM William A Rowe Jr <wr...@rowe-clan.net> wrote: > > On Wed, Mar 13, 2019 at 11:58 AM Yann Ylavic <ylavic....@gmail.com> wrote: > > > The grep-ed double square brackets look weird to me, does not work > > with my (ba)sh at least, so doesn't it enter the > > REPLACE_WITH_YOUR_SHLIBPATH_VAR path anytime? > > I don't think we hit it because we have shlibpath_var previously assigned in > our shell, from the libtoolize steps earlier? > > > Also grep is possibly missing 2>/dev/null to silence ./configure a bit. > > Provided we've picked up shlibpath_var value from the earlier AC_PROG_LIBTOOL > macro but before ./libtool is written and we attempt this eval step, then I > guess all is well and we can mute that.
If libtoolize and/or AC_PROG_LIBTOOL do the work why don't we remove this patch/overwrite?