On Wed, Mar 20, 2019 at 1:18 AM Yann Ylavic <ylavic....@gmail.com> wrote: > > On Tue, Mar 19, 2019 at 5:34 PM William A Rowe Jr <wr...@rowe-clan.net> wrote: > > > > APR has a number of apr.h templates for non-./configure platforms. > > > > It looks like the introduction of timedlocks overlooks these, this needs to > > be fixed before 1.7.0 is tagged. > > > > Yann, would you like to fix? > > What is to fix actually? > ISTM that we don't define APR_HAS_TIMEDLOCKS on ./configure platforms > either, do you mean HAVE_PTHREAD_MUTEX_TIMEDLOCK? > What we have (IIRC) is the runtime APR_THREAD_MUTEX_TIMED flag to be > used at mutex_create() time for portability (i.e. necessary on > platforms that don't have a native waitable mutex mechanism), but > otherwise apr_thread_mutex_timedlock() should be implemented on all > the platforms we support. So what would APR_HAS_TIMEDLOCKS be for?
Hmm, OK, I was looking at trunk code where we don't seem to have this anymore. I'll try to see tomorrow what's missing.. thanks!
