On 10/21/21 12:23 AM, minf...@apache.org wrote:
> Author: minfrin
> Date: Wed Oct 20 22:23:10 2021
> New Revision: 1894423
>
> URL: http://svn.apache.org/viewvc?rev=1894423&view=rev
> Log:
> apr_brigade_split_boundary: Rather than shaving one byte from
> a bucket, ignore the byte instead on the next go-round.
>
> Modified:
> apr/apr/trunk/buckets/apr_brigade.c
>
> Modified: apr/apr/trunk/buckets/apr_brigade.c
> URL:
> http://svn.apache.org/viewvc/apr/apr/trunk/buckets/apr_brigade.c?rev=1894423&r1=1894422&r2=1894423&view=diff
> ==============================================================================
> --- apr/apr/trunk/buckets/apr_brigade.c (original)
> +++ apr/apr/trunk/buckets/apr_brigade.c Wed Oct 20 22:23:10 2021
> @@ -644,11 +647,7 @@ skip:
> *
> * Bump one byte off, and loop round to search again.
> */
> - apr_bucket_split(e, 1);
> - APR_BUCKET_REMOVE(e);
> - APR_BRIGADE_INSERT_TAIL(bbOut, e);
> -
> - outbytes++;
> + ignore++;
Don't we need to reset ignore to 0 after each
APR_BUCKET_REMOVE(e);
APR_BRIGADE_INSERT_TAIL(bbOut, e);
in the code above as we start with a new bucket then again and should use the
what we read from it from the beginning?
Regards
Rüdiger
