On Thu, Dec 2, 2021 at 10:21 PM <mt...@apache.org> wrote: > > Author: mturk > Date: Thu Dec 2 21:21:18 2021 > New Revision: 1895508 > > URL: http://svn.apache.org/viewvc?rev=1895508&view=rev > Log: > Stage 3 in dismantling _WIN32_WCE ... cleanup code > [] > Modified: apr/apr/trunk/threadproc/win32/thread.c > URL: > http://svn.apache.org/viewvc/apr/apr/trunk/threadproc/win32/thread.c?rev=1895508&r1=1895507&r2=1895508&view=diff > ============================================================================== > --- apr/apr/trunk/threadproc/win32/thread.c (original) > +++ apr/apr/trunk/threadproc/win32/thread.c Thu Dec 2 21:21:18 2021 > @@ -138,21 +138,12 @@ APR_DECLARE(apr_status_t) apr_thread_cre > /* Use 0 for default Thread Stack Size, because that will > * default the stack to the same size as the calling thread. > */ > -#ifndef _WIN32_WCE > if ((handle = (HANDLE)_beginthreadex(NULL, > (DWORD) (attr ? attr->stacksize : 0), > (unsigned int (APR_THREAD_FUNC *)(void > *))dummy_worker, > (*new), 0, &temp)) == 0) { > return APR_FROM_OS_ERROR(_doserrno); > } > -#else > - if ((handle = CreateThread(NULL, > - attr && attr->stacksize > 0 ? attr->stacksize : 0, > - (unsigned int (APR_THREAD_FUNC *)(void > *))dummy_worker, > - (*new), 0, &temp)) == 0) { > - return apr_get_os_error(); > - } > -#endif
I'm a bit surprised that _WIN32_WCE used CreateThread() while more recent ones use _beginthreadex(), shouldn't it be the opposite? CreateThread() aligns more with the usual/modern naming convention on Windows.. Regards; Yann.
