On Thu, Jun 23, 2022 at 3:03 AM Ruediger Pluem <rpl...@apache.org> wrote:
>
>
>
> On 6/23/22 1:46 AM, cove...@apache.org wrote:
> > Author: covener
> > Date: Wed Jun 22 23:46:43 2022
> > New Revision: 1902176
> >
> > URL: http://svn.apache.org/viewvc?rev=1902176&view=rev
> > Log:
> > set -lxml2 in non xml2-config case
> >
> > Closes #36
> >
> > Modified:
> > apr/apr/trunk/build/xml.m4
> >
> > Modified: apr/apr/trunk/build/xml.m4
> > URL:
> > http://svn.apache.org/viewvc/apr/apr/trunk/build/xml.m4?rev=1902176&r1=1902175&r2=1902176&view=diff
> > ==============================================================================
> > --- apr/apr/trunk/build/xml.m4 (original)
> > +++ apr/apr/trunk/build/xml.m4 Wed Jun 22 23:46:43 2022
> > @@ -177,6 +177,7 @@ AC_ARG_WITH([libxml2],
> > else
> > xml2_CPPFLAGS="-I$withval/include/libxml2"
> > xml2_LDFLAGS="-L$withval/lib64 -L$withval/lib"
> > + xml2_LIBS="-lxml2"
> > fi
> >
> > APR_ADDTO(CPPFLAGS, [$xml2_CPPFLAGS])
> > @@ -186,6 +187,7 @@ AC_ARG_WITH([libxml2],
> > AC_CHECK_HEADERS(libxml/parser.h, AC_CHECK_LIB(xml2,
> > xmlCreatePushParserCtxt, [apu_has_libxml2=1]))
> > fi
> > ], [
> > + xml2_LIBS="-lxml2"
>
> Why do we need this and if we need it why don't we need
>
> APR_ADDTO(LIBS, [$xml2_LIBS])
>
> as well?
>
> > AC_CHECK_HEADERS(libxml/parser.h, AC_CHECK_LIB(xml2,
> > xmlCreatePushParserCtxt, [apu_has_libxml2=1]))
> > ])
> > AC_SUBST(apu_has_libxml2)
Just past the diff context this flat block exists:
if test ${apu_has_libxml2} = "1" ; then
APR_ADDTO(APRUTIL_CPPFLAGS, [$xml2_CPPFLAGS])
APR_ADDTO(APRUTIL_PRIV_INCLUDES, [$xml2_CPPFLAGS])
APR_ADDTO(APRUTIL_LIBS, [$xml2_LIBS])
fi
