Re: svn commit: r1917047 - in /apr/apr/trunk: CHANGES buffer/ buffer/apr_buffer.c build.conf include/apr_buffer.h test/Makefile.in test/Makefile.win test/NWGNUaprtest test/abts_tests.h test/testbuffer.c test/testutil.h

[Graham Leggett via dev]

On 29 Aug 2024, at 20:46, Ruediger Pluem <rpl...@apache.org> wrote:

>> +        if (src->size < 0) {
>> +            strncpy(dst, src->d.str, (-src->size) - 1);
>> +            dst += (-src->size) - 1;
>> +        }
>> +        else {
>> +            if (APR_BUFFER_NONE == flags) {
>> +                memcpy(dst, src->d.mem, src->size);
> 
> Don't we miss a
> 
> dst += src->size;
> 
> here?
> 
>> +            }

We did, I think I have been chasing this glitch for days. Thank you for finding 
this.

Fixed in r1920293 and updated test to handle concatenation in the opposite 
order.

Regards,
Graham
--