On 21 Mar 2025, at 15:53, Ivan Zhakov <i...@apache.org> wrote: > There some suspicious warnings during build on Windows x64 in apu-1.7.x: > ldap\apr_ldap_option.c(336): warning C4311: 'type cast': pointer truncation > from 'void *' to 'ULONG' > ldap\apr_ldap_option.c(345): warning C4311: 'type cast': pointer truncation > from 'void *' to 'ULONG' > ldap\apr_ldap.c(375): warning C4133: 'function': incompatible types - from > 'apu_err_t **' to 'apr_ldap_err_t **' > ldap\apr_ldap.c(594): warning C4311: 'type cast': pointer truncation from > 'void *' to 'ULONG' > ldap\apr_ldap.c(603): warning C4311: 'type cast': pointer truncation from > 'void *' to 'ULONG' > > The typecast warnings in ldap_set_option() look like a real bug. The attached > patch **should** fix it, but I don't have the environment to test LDAP.
This is an awesome catch. I went digging for example Microsoft code to double check, and this fix makes sense. It's made no difference on COPR (it should not have) and GitHub actions on Windows are happy. > It would be nice to have APR 1.7.5 released for proper APR-Util 1.7.x CMake > testing. See [1]. In this case after APR-Util 1.7.x release we can finally > get proper vcpkg ports for APR and APR-Util. > > [1]: https://lists.apache.org/thread/l0v6k7b6xq85r3x2c3grd768y2lgthsc Will definitely review a release. Regards, Graham --
