On Tue, Jul 8, 2008 at 8:18 PM, Brett Porter <[EMAIL PROTECTED]> wrote:
> Hi Deng,
>
> Great to see this finally added back in, thanks :D
>
> A few quick questions...
>
> On 08/07/2008, at 6:44 PM, [EMAIL PROTECTED] wrote:
>
> + public IndexJavaPublicMethodsConsumer()
>> + {
>> + includes.add( "jar" );
>> + includes.add( "war" );
>> + includes.add( "ear" );
>> + includes.add( "zip" );
>> + includes.add( "tar.gz" );
>> + includes.add( "tar.bz2" );
>> + includes.add( "car" );
>> + includes.add( "sar" );
>> + includes.add( "mar" );
>> + includes.add( "rar" );
>> + }
>>
>
> why zip, tar.* ?
>
> + if( file.getAbsolutePath().endsWith( ".jar" ) ||
>> file.getAbsolutePath().endsWith( ".war" ) ||
>> + file.getAbsolutePath().endsWith( ".ear" ) ||
>> file.getAbsolutePath().endsWith( ".zip" ) ||
>> + file.getAbsolutePath().endsWith( ".tar.gz" ) ||
>> file.getAbsolutePath().endsWith( ".tar.bz2" ) ||
>> + file.getAbsolutePath().endsWith( ".car" ) ||
>> file.getAbsolutePath().endsWith( ".sar" ) ||
>> + file.getAbsolutePath().endsWith( ".mar" ) ||
>> file.getAbsolutePath().endsWith( ".rar" ) )
>>
>
> Isn't this assumed from the includes?
I don't think the includes is currently working for the db consumers so I
added the check in the processArtifact.
I was meaning to look further into this includes problem later..
>
>
>
>> Added:
>> archiva/trunk/archiva-modules/archiva-base/archiva-consumers/archiva-lucene-consumers/src/test/java/org/apache/maven/archiva/consumers/lucene/IndexJavaPublicMethodsCrossRepositorySearch.java
>>
>
> There seem to be a few dumped exceptions in here?
Right, I'll put some logs for these exceptions.
>
>
> Cheers,
> Brett
>
> --
> Brett Porter
> [EMAIL PROTECTED]
> http://blogs.exist.com/bporter/
>
>
Thanks,
Deng
