Re: svn commit: r924673 - in /archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test: ArtifactManagementTest.java RepositoryTest.java parent/AbstractArchivaTest.java parent/AbstractRepositoryTest.jav

[Marecor Baclay]

On Fri, Mar 19, 2010 at 9:36 AM, Deng Ching <och...@apache.org> wrote:

> On Thu, Mar 18, 2010 at 5:25 PM, <mbac...@apache.org> wrote:
>
> > Author: mbaclay
> > Date: Thu Mar 18 09:25:09 2010
> > New Revision: 924673
> >
> > URL: http://svn.apache.org/viewvc?rev=924673&view=rev
> > Log:
> > [MRM-1323] archiva webapp tests failed to run in internet explorer
> > Submitted by: Gwen Harold Autencio
> >
> >
> > Modified:
> >
> >
>  
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> >
> >
>  
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/RepositoryTest.java
> >
> >
>  
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractArchivaTest.java
> >
> >
>  
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/parent/AbstractRepositoryTest.java
> >
> > Modified:
> >
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> > URL:
> >
> http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java?rev=924673&r1=924672&r2=924673&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> > (original)
> > +++
> >
> archiva/trunk/archiva-modules/archiva-web/archiva-webapp-test/src/test/testng/org/apache/archiva/web/test/ArtifactManagementTest.java
> > Thu Mar 18 09:25:09 2010
> > @@ -96,15 +96,15 @@ public class ArtifactManagementTest
> >     @Test( groups = "requiresUpload" )
> >     public void testDotNetTypes()
> >     {
> > -        addArtifact( getGroupId(), "testDotNetTypes", getVersion(),
> > "library", getArtifactFilePath(),
> > +        addArtifact( "dotNetTypes", "dotNetTypes", getVersion(),
> > "library", getArtifactFilePath(),
> >                      getRepositoryId() );
> > -        assertTextPresent( "Artifact 'test:testDotNetTypes:1.0' was
> > successfully deployed to repository 'internal'" );
> > -        getSelenium().open( baseUrl + "/browse/" + getGroupId() +
> > "/testDotNetTypes/" + getVersion() );
> > +        assertTextPresent( "Artifact 'dotNetTypes:dotNetTypes:1.0' was
> > successfully deployed to repository 'internal'" );
> > +        getSelenium().open( baseUrl + "/browse/" + "dotNetTypes" +
> > "/dotNetTypes/" + getVersion() );
> >         waitPage();
>
>
> >         assertTextPresent( "<type>library</type>" );
> >         String basePath =
> > -            "/archiva/repository/internal/" + getGroupId() +
> > "/testDotNetTypes/" + getVersion() + "/testDotNetTypes-" +
> > +            "/archiva/repository/internal/" + "dotNetTypes" +
> > "/dotNetTypes/" + getVersion() + "/dotNetTypes-" +
> >                 getVersion();
> >
>
> Can we add the groupId, artifactId and version for the dotnet types test to
> testng.properties instead of having it hard coded in the tests please? :)
>

Ok. Will do.. Thanks Deng! :-)


>
> Thanks,
> Deng
>