Great, thanks. Just needed to get a cup of coffee before writing it up ;) I'll add my findings over there
Greetings -Sascha- Am 30.04.2014 08:44, schrieb Olivier Lamy: > done here: http://jira.codehaus.org/browse/MRM-1837 > > > > On 30 April 2014 16:24, Olivier Lamy <[email protected]> wrote: >> good catch!!!! >> Can you create a Jira for that, I have some ideas to fix it. >> OMG sometimes I write comments finally :-) >> Anyway this one could improve a bit but it's not the real problem. >> The main issue with this refactoring is to rewrite the content >> consumer and break backward compat for folks who wrote their own >> consumers :-( >> >> >> On 30 April 2014 02:12, Sascha Vogt <[email protected]> wrote: >>> Hi all, >>> >>> I think we found a memory leak. >>> >>> In a heap dump taken while Archiva was pretty busy doing GCs, we found >>> DefaultArchivaConfiguration to be holding references to 10.000 >>> registryListeners (which in turn had Jackrabbit XASessionImpls) and >>> occupied 84 of our 4GB heap. >>> >>> Is this related to the following comment we found: >>> >>> /** >>> * A consumer of content (files) in the repository. >>> * >>> * olamy: TODO/FIXME we must review this api, in the current situation we >>> use prototype beans rather than singletons >>> * this is a bit memory consuming the better will be to ConsumerContext >>> bean to transport repository context etc... >>> */ >>> public interface RepositoryContentConsumer >>> >>> Will the registryListeners ever be cleaned up? Any ideas how to address >>> that?
