1. in FigAssociation, I find a "private FigText srcMult;" and in
FigAssociationEnd, I also find a "private FigText srcMult;", which is now
the correct one?
I'll do similar changes in FigAssociationEnd and hopefully move
duplicate logic to some sensible place. I'll take a look. Remember
FigAssociationEnd is the edge for a n-ary association, it's not a part
of FigAssociation.
2. I get warnings when changing the multiplicity/ordering/isNavigable of an
association:
WARN: Got an event with a property we're not registered for
multiplicity (FigAssociation.java:288)
WARN: Got an event with a property we're not registered for ordering
(FigAssociation.java:288)
WARN: Got an event with a property we're not registered for
isNavigable (FigAssociation.java:288)
Thanks for reminding me. I meant to raise this ion the dev list.
FigAssociation is now registering for events with very specific properties
In setOwner I do -
addElementListener(getOwner(), new String[] {"name", "isAbstract"});
So why am I getting these warning? Is there something somewhere else
that is register FigAssociation for all events or is there some
problem in the event pump?
I can investigate further but I was hoping somebody might know. It's
silly for me to restrict listeners if something else is registering
for everything.
3. Did you plan on having the FigMultiplicity listen to the "multiplicity"
event?
This should be working. If you amend the multiplicity in the prop
panel you'll see that the diagram changes.
See the call to super(...) in the FigMultiplicity constructor.
FigSingleLineText is now able to manage addition and removal of the
listener accoring to the parameters of its constructor.
With regards to your suggestion that Notations listen to the model and
Figs listen to notations -
I was think that the setOwner method of FigSingleLineText could test
to see if the owner given is a instance of NotaionProvider4. If so it
simply listens to that instead (and remove in removeFromDiagram). It
should also except that notation as an alternative constructor
argument.
public FigSingleLineText(int x, int y, int w, int h, boolean
expandOnly, NotationProvider4 notationProvider)
With this there would be no need for a FigMultiplicity class. You can
simply create a FigSingleLineEdit with the notation provider as an
argument.
BTW - I've undeprecated setOwner in GEF. The problem was I think our
usage of the method not it's existence. Other GEF apps may want to use
this.
We really want to make to all Fig constructors taking the owner as a
constructor argument and then never change it. I've done some work
locally to do this for FigAssociation. It worked but there was some
odd positioning of the annotaions on reload. I'll commit when I've got
that working.
Bob.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
