> I would prefer to name the interface "Project", and the original
> "ProjectImpl". IIRC, Bob is using this naming, too.
I have hard time getting excited about naming, so that's fine with me. Is
there an Eclipse refactoring that I can use that will rename a base class
and extract an interface in a single step?
> In what package do the interfaces go?
I'm not changing packaging at all. Interfaces go in the same package as the
classes they were extracted from. Classes which are split up all stay in
the same package.
> In other words, what do you repklace
> all these calls with:
> Project p = ProjectManager.getManager().getCurrentProject();
> ProjectSettings ps = p.getProjectSettings();
Most of those should change into
ProjectSettings ps = getProject().getProjectSettings();
where getProject() is a method provided by ArgoDiagram, FigNodeModelElement,
UMLGraphModel, etc. These methods exist already, so I'm not sure why
they're not being used. The more the getCurrentProject() method is used,
the harder it is going to be to introduce multiple project support. Of
course, sometimes you really do want the *current* project, but most of the
time what you're really looking for is the *owning* project for the thing
you are working with.
> > I've also introduced a new event
> > for the status updates that the status bar listens to
> > so that other classes can just post status events
> > rather than calling ProjectBrowser directly.
>
> I already introduced this - see the ArgoHelpEvent class.
> It is used in Notation. My idea was that in the future, more
> "help" methods
> may be added, so I did not name it ArgoStatusBarEvent or something.
I did see that, but help seems semantically different to me than status
updates. Of course it's easy to merge them, but I'm wondering if there's
value to keeping them separate. In addition to simple textual status
events, there are also save/load project events which are used by the
ProjectBrowser to do things like update the file MRU list. A project save
event is pretty different from a help event.
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
