> This commit creates an error in eUML. Please look at the 
> explanation in-line bellow.

This was changed yesterday (about 26 hours ago).  Are you synchronized with
the current SVN?

> If "loadProfile(modelFilename)" returns null, a 
> NullPointerException is thrown in elements.addAll(null).
> 
> Could you please change this into:
> +            Collection c = loadProfile(modelFilename);
> +            if (c != null) {
> +                elements.addAll(c);

A method declared to return a Collection should never return null, because
then it always has to be tested for.  I changed loadProfile to return an
empty collection if it doesn't load a profile.

By the way, please try to cut down the quoted text to just what is relevant
to your message.  I skimmed the rest of the patch for comments by you and
didn't see any, but hopefully I didn't miss one buried in all the text.

Tom

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to