On Nov 23, 2007 3:31 PM, Michiel van der Wulp <[EMAIL PROTECTED]> wrote:
> But I would like to go a bit further now to solve a dependency problem, such
> as org.argouml.ui.DetailsPane depends on
> org.argouml.cognitive.checklist.ui.TabChecklist, which it shouldn't (you
> removed the test that enforced it).
Are you talking about this code declaring that
org.argouml.cognitive.checklist.ui. is a top level package (and
unused)?
String[] top = {
...
// The following 2 are not supposed to pass, but they do.
// Hence these packages are not used anywhere:
"org.argouml.cognitive.checklist.ui",
"org.argouml.util.osdep.win32",
I removed the check because a) the package is used (although the use
was hidden before) and b) it's not a top level package. The second
package truly was unused, so I deleted it and the check.
> How about the attached patch?
> This way, the Main class puts the UI together from otherwise independent
> subsystems.
It doesn't seem correct to me that the main class should know about
the internal contents of the property panel. I think the DetailsPane
should a) determine the default contents of the pane itself and b)
provide an extension mechanism for other subsystems (including
external modules) to add additional panels.
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
