On Sun, Mar 30, 2008 at 6:07 PM, Scott Roberts <[EMAIL PROTECTED]> wrote: > I've created some more tests (patch below) for following classes:
Thanks for the contribution. I've committed the tests pretty much as you submitted them. Minor changes that I made: - Added @author annotations for you. Let me know if you're prefer not to have them. - Added some missing Javadoc for a public method (you should be able to set your development environment up to catch this and warn you) - Removed overriden method implementations which consist of nothing but calling the superclasses method. These don't really add any value. - Removed Javadoc which consisted of solely @see tags. This confuses Eclipse and it gives better tooltips if it can just go directly to the superclass' Javadoc. > The test for ArgoEventPump currently fails for an issue which I've > documented in the bugtracker. > http://argouml.tigris.org/issues/show_bug.cgi?id=4995 > The issue is that the pump will call listeners for event types for > which they did not register. Some aroguml code may have come to rely > on this behavior but to me it seems incorrect. Take a look at the > issue which includes a patch and let me know what you think. Thanks for the bug report. Generally speaking event listeners should be conservative about checking the types of events they receive because the event registrations may get changed in a superclass or some other separate piece of code, so this should mainly be a performance issue, but it's still good to have it on the list to look at. Tom --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
