>On Fri, Apr 4, 2008 at 3:32 PM, Tom Morris <[EMAIL PROTECTED]> wrote: > Thanks for the contribution. I've committed the tests pretty much as > you submitted them. > > Minor changes that I made: > - Added @author annotations for you...
Thanks for committing the change. I'll be sure to comply with the other things you mentioned going forward. > > > The test for ArgoEventPump currently fails for an issue which I've > > documented in the bugtracker. > > http://argouml.tigris.org/issues/show_bug.cgi?id=4995 > > Thanks for the bug report. Generally speaking event listeners should > be conservative about checking the types of events they receive > because the event registrations may get changed in a superclass or > some other separate piece of code, so this should mainly be a > performance issue, but it's still good to have it on the list to look > at. > Something else to consider in addition to the performance issue is the possibility a new bug is created by the addition of an event listener that doesn't follow convention. I've added a patch to the issue which potentially corrects the issues. Please check it out when you get a chance. FYI, this test catches the issue and will fail until the issue is corrected. http://argouml-stats.tigris.org/nonav/reports-java5/junit/org/argouml/application/events/1_TestArgoEventPump.html --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
