Review of this will be slower because you have not only changed code but also moved classes.
I can see why you've done that but it makes a diff difficult to view real change. Any chance of an adjusted patch without so much movement of code. We can then do further refactoring later if required. Please attach it to issue 1009, I'm cc-ed there so will see it when it arrives. Bob. On 18/04/2008, Bob Tarling <[EMAIL PROTECTED]> wrote: > Hi Scott > > For future reference I would suggest attaching patches to the issue > itself rather than the dev list. > > By all means then drop a line on the dev list if you then want to > highlight the issue. > > That way it is less likely that a patch gets lost at the bottom of > someones inbox should all the devs be busy on other matters at that > moment. > > I will try to take a look at this one asap though. > > > Bob. > > > > On 18/04/2008, Scott Roberts <[EMAIL PROTECTED]> wrote: > > I've attached a patch for this feature, which includes: > > > > 1) Added functionality to display the 'Create Model Elements' menu > > when any of the following objects are selected: Model, Package, Class, > > Actor, Use Case, Component, Component Instance, Interface, Node, Node > > Instance. The menu is dynamically created and displays the following > > options for each respective element: > > > > Model: New Package, New Actor, New Use Case, New Class, New Interface, > > New Component, New Component Instance, New Node, New Node Instance, > > New Stereotype > > Package: New Package, New Actor, New Use Case, New Class, New > > Interface, New Component, New Node, New Stereotype > > New Class: New Attribute, New Operation, New Class, New Reception, New > > Stereotype > > Actor: New Reception, New Stereotype, > > Use Case: New Extension Point, New Attribute, New Operation, New > > Reception, New Stereotype > > Component: New Reception, New Stereotype > > Component Instance: New Stereotype > > Interface: New Operation, New Reception, New Stereotype > > Node: New Reception, New Stereotype > > Node Instance: New Stereotype > > > > 2) All of the new menus have icons and labels that use the same > > properties as the buttons on the diagrams. This is similar to the > > existing Create Diagrams menu. > > 3) I combined the existing logic used for creating relationship model > > elements with this new logic. I've also updated the relationship > > elements to use icons and labels as the the other menus. > > 4) I removed the Add Package menu item since that functionality is now > > more consistently available through the Create Model Element menu. > > 5) I did not add any of the short-cuts yet but I am keeping this in > > mind because the other Explorer menus need these as well. > > > > All of the logic and code for this menu has been encapsulated in a new > > class, org.argouml.ui.explorer.CreateModelElementMenu. Some small > > changes were made to org.argouml.ui.explorer.ExplorerPopup to > > integrate this new menu. > > > > Ultimately this menu should offer all options for all possible menu > > elements. There are a lot of permutations to be developed and tested > > so it would be great if sets of changes could be committed to the > > repository at appropriate milestones. > > > > Take a look at what I have provided and let me know what you think. > > It would be awesome if the first phase of this feature was committed > > prior to Flag Day. > > > > Thanks, > > > > Scott > > > > > > On Tue, Apr 15, 2008 at 9:42 PM, Scott Roberts <[EMAIL PROTECTED]> wrote: > > > Please ignore my last message, I accidentally hit send button too early. > > > > > > Luis, I think the short-cuts are a good idea and I think that they > > > should be enabled on all the Explorer menus. I will look to > > > incorporate them into these new menus. > > > > > > Bob, I agree with what you are saying about making the menu dynamic > > > depending on the element that is selected. So when a user > > > right-clicks an element they are presented with a Create Model Element > > > sub menu, which contains the elements that correspond to the selected > > > item. It seems like there are a considerable amount of permutations > > > of the dynamic menu so below is what I am thinking of delivering > > > initially. > > > > > > Right-Click Model: Create Model Element -> Create Package > > > Right-Click Package: Create Model Element -> Create Package, Create > > > Actor, Create Use Case, Create Class, Create Interface, Create > > > Component, Create Node, Create Stereotype > > > Right-Click Actor: Create Model Element -> Create Reception, Create > Stereotype > > > Right-Click Use Case: Create Model Element -> Create Attribute, Create > > > Operation, Create Extension Point, Create Reception, Create Stereotype > > > Right-Click Component: Create Model Element -> Create Reception, > > > Create Stereotype > > > Right-Click Interface: Create Model Element -> Create Operation, > > > Create Reception, Create Stereotype > > > Right-Click Node: Create Model Element -> Create Reception, Create > Stereotype > > > Right-Click Class: Create Model Element -> Create Attribute, Create > > > Operation, Create Inner Class, Create Reception, Create Stereotype > > > > > > Let me know what you think about these options for the first patch of > > > the feature. > > > > > > Thanks, > > > Scott > > > > > > > > > On Tue, Apr 15, 2008 at 8:13 PM, Luis Sergio Oliveira <[EMAIL > PROTECTED]> wrote: > > > > Scott Roberts wrote: > > > > > Both of those ideas sound good so let me sum it up here what I think > > > > > we want to go with: > > > > > > > > > > + Make the menu context sensitive so that when a user righ-clicks > on a > > > > > particular diagram, the context menu includes a Create Model Element > > > > > item which has a submenu containing all of the elements that > > > > > correspond to that diagram. So for example if the user were to > > > > > right-click on a Class Diagram they would see: > > > > > Create Model Element > > > > > Class > > > > > Datatype > > > > > > > > > > > > > > > > > > > Hmm, probably I wasn't clear. My concern is that this context menu > will pop > > > > when an appropriate model element is selected and a keyboard shortcut > is > > > > pressed. This is something that is already available in eclipse, for > some > > > > menus, such as the Alt-SHIFT-X button shortcut in eclipse, which show > a > > > > context menu with options for running "something" based on the > context. > > > > > > > > This would enable less mouse usage and probably enable access to the > popup > > > > menu and associated functionality even if the selected object is in > explorer > > > > or some diagram. > > > > > > > > But, maybe this is a bit OT from your initial proposal... > > > > > > > > Luis > > > > > > > > > > > > > > > > > > > > > > > On Tue, Apr 15, 2008 at 5:57 PM, Luis Sergio Oliveira <[EMAIL > PROTECTED]> > > > > wrote: > > > > > > > > > > > > > > > > Scott Roberts wrote: > > > > > > > > > > > > > > > > > > > Feature > > > > > > > --------------------------- > > > > > > > Add the ability for users to create all model elements using the > > > > Explorer. > > > > > > > > > > > > > > Objective > > > > > > > --------------------------- > > > > > > > The objective of this feature is to enhance the user's ability > to > > > > > > > create UML objects via the Explorer. This provides users that > prefer > > > > > > > the Explorer interface more flexibility and adds consistency to > the > > > > > > > overall user interface thereby making the application more > intuitive > > > > > > > and user-friendly. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Very interesting. Please consider (if not enabled by default) > having a > > > > > > keyboard short-cut for each group of sub-menus with appropriate > key to > > > > > > invoke a menu item. > > > > > > > > > > > > I.e.: C-K opens the "Create Class Element" sub-menu, being each > of the > > > > > > options (menu items associated with a key stroke). > > > > > > > > > > > > Regards, and thanks for the proposal, > > > > > > > > > > > > Luis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
