[argouml-dev] Less strict checkstyle checking for empty blocks containing comments

[Michiel van der Wulp]

Hi *,

Is it OK if we relax the empty block style check, to allow a block with 
comments?

I mean the following:
This piece of code gives a style warning (taken from 
ClassifierRoleNotationUml), because there is no statement in the if clause:

if (" ".equals(token) || "\t".equals(token)) {
   /* Do nothing. */
} else if ("/".equals(token)) {
     hasSlash = true;
    ...

See http://checkstyle.sourceforge.net/config_blocks.html:
We can relax this by adding this to the checkstyle configuration:
<module name="EmptyBlock">
  <property name="option" value="text"/>
</module>


Shall I perform this change to 
/argouml-core-tools/checkstyle/checkstyle_argouml.xml ?

Regards,
Michiel 


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]