Hi Tom, Bob, On Thu, May 8, 2008 at 8:12 PM, Tom Morris <[EMAIL PROTECTED]> wrote: > I presume that Model.getCommandStack is another thing that we want to > go away before the release. What isn't clear to me is all the work > that needs to be done. The interface ModelImplementation doesn't > appear to have any other method that requires Model subsystem > implementations to implement an undo mechanism. Is it intended that > this be optional? How do they pass momentos back to get pushed on the > stack? > > Bob - can you clarify API issues? > Bogdan (Pistol) - can you comment on how the proposed API would work > (or not) with the eUML implementation?
The eUML model used the stack to save the state. ArgoUML core used the stack (retrieving through the Model.getCommandStack() ) to undo/redo the eUML model state. Only eUML was pushing data on the stack, the undo mechanism designed by Bob (with mementos) wasn't used. All this was done for the eUML demonstration as a workaround, it was not a proposed API. It shouldn't have been in the first place in trunk. IMO it needed be removed from trunk - which you just did. Bogdan --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
