Hello Dave!

I agree that it would be a good idea to work to reduce these warnings.
Lately, I have not felt it important enough to work with since this is not
on the top of my priority list so I have just attempted to fix as many
warnings as I can in the files that I have otherwise modified.

A couple of years back Michiel made a huge effort and reduced the checkstyle
warnings from 23000 (august 2003) to 22 (april 2005). Since then the amount
of warnings have been slowly increasing again and is now at around 650 (in
comparison). We also have enabled a few "good practise" warnings from within
Eclipse.

 You are most welcome to fix all these warnings. Be prepared that there is a
lot of, not very rewarding, work to do so.

I think that these warnings are stored in the Eclipse settings in the
repository so every developer should have the same settings from the project
(as long as Checklipse is installed). If they are not, please make sure they
are. I had a plan to write a script to check that the Eclipse project
settings are exactly the same in all projects but I haven't gotten around to
it. Anyone can do that.

What we also should do is to improve the awareness of these warnings and
decide under what circumstances (if any) it is "allowed" to commit code with
new warnings. If you work with the warnings, you could conduct this
discussion while you encounter the problems.

        /Linus


2008/6/23, Dave Thompson <[EMAIL PROTECTED]>:
>
> Hi All,
>
> Currently ArgoUML compiles with many 1000s of warnings (9369 on my setup).
>
> I know that different people have different opinions on warnings, and
> whether they should be allowed in long-term code or not.
>
> My opinion is that compiler warnings can be helpful, as they sometimes
> highlight faults in the code, which aren't otherwise noticed.  They also
> draw attention to deprecated methods, and unused variables.  However, if a
> small number of new warnings are masked by thousands of historic ones, the
> warning mechanism as a development aid is almost useless.
>
> What is the official line on this?  Would anyone object to a tidy-up, where
> we tried to reduce the number of warnings?  Is this activity worthwhile?
>
> Dave
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

Reply via email to