This week I worked on: + the OCL interpreter (issue 5042) + created a propertypanel for critics and organized the existing WFRs as Profiles containing only critics (issue 5029) + worked on issue 5163
Next steps: + finish the OCL interpreter + I have no more coding tasks for issue 5029, apart from writing tests and do some little enhancements, I think something that should deserve some attention is the textual description of the critics. I think we could improve their quality by using a more structured template. For example, let's take the CrAttrNameConflict. The current description is: "Attributes must have distinct names. This critic may have been triggered as the result of an inherited attribute name. Clear and unambiguous naming is a key element in code generation and serves to make the design more understandable and maintainable. To address this use the "Next>" button, or manually select the one of the conflicting attributes of this class and change its name. " Apart from the fact that this critic has no wizard - so the "next button" advice is plain wrong; I would rewrite it as: DETAILS: Attributes must have distinct names. Clear and unambiguous naming is a key element in code generation and serves to make the design more understandable and maintainable. SOLUTION: Click on the "Next>" button to let a wizard help you solving this problem or revise manually the attribute names and make sure they all have distinct names. MORE INFO: Well-formedness rule [2] for Classifier. See page 29 of UML 1.1, Semantics. OMG document ad/97-08-04. See page 2-49 in UML V1.3 I would also revise the headline string, the current one is: "Revise Attribute Names to Avoid Conflict" My suggestion "Revise Attribute Names" (looks like a ToDo) or "Duplicated Attribute Definition" (looks like a critic) + I have a doubt in the critic definition: what is the "addTrigger" call in the constructors for? and what's is the difference between that and the metaclass passed when registering a critic? *maas* - http://www.marcosaurelio.com *1984 +2057 "Graduate school is like teaching swimming by tossing students into the deep end of the pool and seeing who makes it to the other end alive and who drowns. " - Ronald T. Azuma
