Hi Bogdan,

It would be wise to state clearly in the contract for the NotationName.setNotationOffset(int offset) method that the value should be frozen, once set. Maybe you can even implement this by refusing any change once the value was already set to a non-zero value. This will reduce the problem of changing offsets to notation language changes.

With the Dialog font 16 points, the toggling in Java notation for a "protected void newOperation()" still works in the space after the void, so the area is a bit wide. This may obscure the normal editing mode for double-clicking - which is bad. In fact, wherever you double-click on "final int newAttr", the visibility is toggled, and you do not enter editing mode. Maybe you can detect double-clicking and not toggle visibility, but go to edit mode?

I still think that this feature needs some visual indication to be usefull - there are too many hidden features already in ArgoUML.
Why not create a toolbelt-button (selection action button) instead?
I mean a button that appears at the left hand side of the text when the text is selected, and the mouse is hovering over the fig.

I do not understand your question: "Where should I put the code to set this offset in order to execute it every time the notation changes, ..."

Since you do this in FigOperation, it seems to be working:
int offset = ProjectManager.getManager().getCurrentProject().getProjectSettings().getNotationName().getNotationOffset();
The value is taken from the NotationName every time...

BTW: You should shorten ProjectManager.getManager().getCurrentProject() to "getProject()", to prevent dependency on the kernel.

Regards,
Michiel


----- Original Message ----- From: "Bogdan Szanto" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Thursday, August 07, 2008 2:22 PM
Subject: [argouml-dev] RFH - Notation


Hello all,
I've searched high and low on how to do this but I can't seem to find the solution. For feature 3 - Class modification on the panel (http://argouml.tigris.org/issues/show_bug.cgi?id=5140), I need a width in pixels in which if the user clicks, the visibility of the attribute/operation will be changed. In order to do this the cleanest way, every notation type should set this offset in function of the way it displays visibility (UML uses signs +/-/#/~, while Java user words public/private/protected/package... and so on). So what I need is, when the user changes the notation, the new active notation should set this offset via the NotationName.setNotationOffset(int offset) method. Here the offset is expressed in number of letters (the job converting this in pixels is OK). Where should I put the code to set this offset in order to execute it every time the notation changes, and from the selected notation ('from' here means that the notation changes this offset, and it's not an if-else if-else in an action or smtg). I hope I explained well enough to be understood.

Regards,
Bogdan, at wits end

--
Bogdan SZANTO
-----------------------------------------------
Impossible is nothing ~ Nothing is impossible !
-----------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


No virus found in this incoming message.
Checked by AVG - http://www.avg.com Version: 8.0.138 / Virus Database: 270.5.12/1597 - Release Date: 8/7/2008 5:54 AM





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to