Hi Christian! > Within the code of the generator, there are a lot of if's like "if > (version > 4) ... else ...". I believe that these cases should be > encapsulated within a class for the specific version, like 4 or 5. (By > that I mean that these if's are replaced by a call of a method on an > object representing the selected PHP-Version, e.g. 4 or 5, which then > decides what to do, as this shouldn't be what the generator itself is > supposed to do.)
I agree! > I furthermore would like to point out that even the development of > security fixes of PHP4 has been discontinued since Dec. 2007. > Therefore, we should discuss deactivating the PHP4-CG (at least) by > default. (I by myself would stop supporting PHP4 in upcoming versions of > ArgoUML in general.) With the PHP4 generator in a separate class, as you suggested above, you are free to further develop PHP5 support with no PHP4 getting in the way. Then we can keep the PHP generator and take the time to carefully decide when PHP4 generation will be turned off. > Next question is: I found it *very* confusing that a method called > "setFilename" calls several other methods like "updateFile" and > eventually generates a file with a comment in it. I would really like to > clean / restructure the code but I'm not quite sure in which way other > applications rely on it. Do you think that there might occur severe > problems by renaming / restructuring? (I do believe that these classes > are only used within the ArgoUML-PHP-Project, but I'm not quite sure so > I better ask) No code relies on the PHP code, so feel free to enhance this indeed strange code structure! Thanks for getting involved! Thomas -- Aufgepasst: Sind Ihre Daten beim Online-Banking auch optimal geschützt? Jetzt informieren und absichern: https://homebanking.web.de/?mc=m...@footer. ------------------------------------------------------ http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=1338410 To unsubscribe from this discussion, e-mail: [[email protected]]. To be allowed to post to the list contact the mailing list moderator, email: [[email protected]]
