I tried merging myself. I simply didn't bother to implement the new SequenceDiagram interface.
All appears to work fine for me in the branch at the moment. Please test yourself and then go ahead with alpha release. Regards Bob. 2009/6/30 Linus Tolke <[email protected]>: > Hi Bob! > These changes by themselves, do not compile (or I have made a misstake > merging). I will have to investigate this further. > The problem is the getCollaboration() function. > /Linus > > 2009/6/28 Bob Tarling <[email protected]> >> >> r17149 through to r17152 is also required for my part of the fix. >> >> I think Christians patch should be taken also to allow comments in SD. >> Christian could you give Linus a hand with what he needs for that? >> >> From what I remember of what Michiel said his changes were for >> standardising some internals so should have no effect for the user. >> >> Regards >> >> Bob. >> >> 2009/6/28 Linus Tolke <[email protected]>: >> > I have now merged this (r17147 only) into the release branch. >> > The other stuff that you wanted to include, Bob, what is that and how >> > shall >> > we handle that? >> > /Linus >> > >> > 2009/6/28 Linus Tolke Tigris <[email protected]> >> >> >> >> Hello Bob! >> >> This approach doesn't work. The problem is that the updated trunk >> >> relies >> >> on the new SequenceDiagram interface introduced in the argouml.jar. >> >> I am not enthusiastic about merging in more stuff outside of the >> >> sequence >> >> diagrams jar to get this to work. I prefer that we instead merge >> >> everything >> >> except the introduction of the SequenceDiagram into the sequence >> >> diagram jar >> >> for 0.28.1. My problem is that I don't know exactly how things are >> >> related. >> >> I will start by attempting to merge just the solution to 5811 (r17147). >> >> /Linus >> >> >> >> 2009/6/26 Bob Tarling <[email protected]> >> >>> >> >>> I'd recommend copying all of the sequence diagram code to the branch >> >>> so that we have the other fixes discussed earlier in this thread. >> >>> >> >>> Then go to alpha release as soon as possible. >> >>> >> >>> Regards >> >>> >> >>> Bob. >> >>> >> >>> >> >>> 2009/6/26 Thomas Neustupny <[email protected]>: >> >>> > Hi Bob and Linus, >> >>> > >> >>> > I verified the fix and added a little test report to the issue. Too >> >>> > bad >> >>> > that Michael Jackson will never benefit from your great fix, thanks >> >>> > Bob! ;-) >> >>> > >> >>> > Linus, I suggest to add the fix to the 0.28.x branch. >> >>> > >> >>> > Thomas >> >>> > >> >>> > -------- Original-Nachricht -------- >> >>> >> Datum: Thu, 25 Jun 2009 08:23:43 +0100 >> >>> >> Von: Bob Tarling <[email protected]> >> >>> >> An: [email protected] >> >>> >> Betreff: Re: [argouml-dev] Sequence diagram problems >> >>> > >> >>> >> Oops, I meant >> >>> >> >> >>> >> Once issue 5811 is verified...... >> >>> >> >> >>> >> Could somebody please verify my fix there and then we can go ahead. >> >>> >> >> >>> >> Regards >> >>> >> >> >>> >> Bob. >> >>> >> >> >>> >> 2009/6/24 Bob Tarling <[email protected]>: >> >>> >> > I've completed work on the fix. >> >>> >> > >> >>> >> > Once issue 5811 is resolved I'd recommend that the complete >> >>> >> > source >> >>> >> > of >> >>> >> > sequence diagrams is copied to the new branch and an alpha build >> >>> >> > is >> >>> >> > made for our own initial testing. >> >>> >> > >> >>> >> > Regards >> >>> >> > >> >>> >> > Bob. >> >>> >> > >> >>> >> > >> >>> >> > 2009/6/21 Bob Tarling <[email protected]>: >> >>> >> >> Hi Linus >> >>> >> >> >> >>> >> >> I haven't had time yet to do any further work but I think there >> >>> >> >> is >> >>> >> >> some work required to fix projects that have already become >> >>> >> >> corrupt >> >>> >> >> since 0.28. >> >>> >> >> >> >>> >> >> Please wait till this is done before making a build. I'll drop a >> >>> >> >> line >> >>> >> >> when ready. >> >>> >> >> >> >>> >> >> Regards >> >>> >> >> >> >>> >> >> Bob. >> >>> >> >> >> >>> >> >> 2009/6/21 Linus Tolke <[email protected]>: >> >>> >> >>> Hello Bob! >> >>> >> >>> I didn't see any XSLT additions in the commit and from your >> >>> >> >>> comment >> >>> >> about >> >>> >> >>> reinstating after load I conclude that an XSLT fix was not >> >>> >> >>> needed. >> >>> >> >>> Then this means that it is an update only of the sequence >> >>> >> >>> diagrams >> >>> >> >>> module. Is that correct? >> >>> >> >>> If so, we need to decide on how to do the release. My scripts >> >>> >> >>> that >> >>> >> builds >> >>> >> >>> all the zip and tar files, more or less requires that >> >>> >> >>> everything >> >>> >> >>> is >> >>> >> rebuilt. >> >>> >> >>> On the other hand, I have the 0.28 sources so that we could >> >>> >> >>> rebuild >> >>> >> just >> >>> >> >>> what is needed. The version number that appears when starting >> >>> >> >>> ArgoUML >> >>> >> is in >> >>> >> >>> the main jar (argouml.jar) so if we want that to be updated, we >> >>> >> >>> need >> >>> >> to >> >>> >> >>> deliver a new one of those. >> >>> >> >>> Perhaps the best thing is to run the complete release >> >>> >> >>> procedure. I >> >>> >> will >> >>> >> >>> start by creating the release branch for 0.28.x releases in all >> >>> >> involved >> >>> >> >>> repositories. >> >>> >> >>> /Linus >> >>> >> >>> 2009/6/18 Bob Tarling <[email protected]> >> >>> >> >>>> >> >>> >> >>>> The defect is fixed so I think it would be possible to release >> >>> >> >>>> this >> >>> >> as >> >>> >> >>>> a single jar update. >> >>> >> >>>> >> >>> >> >>>> The only problem is any user projects that have already become >> >>> >> corrupt >> >>> >> >>>> as a result of this. >> >>> >> >>>> >> >>> >> >>>> I may be able to write some XSLT that will combine all >> >>> >> >>>> elements >> >>> >> >>>> in a >> >>> >> >>>> (new style) sequence diagram to the same collaboration. >> >>> >> >>>> >> >>> >> >>>> I might have time before the weekend to investigate if that >> >>> >> >>>> can >> >>> >> >>>> be >> >>> >> done. >> >>> >> >>>> >> >>> >> >>>> As work towards 0.30 seems quiet at the moment I think its >> >>> >> >>>> worth >> >>> >> >>>> considering a defect release for this. >> >>> >> >>>> >> >>> >> >>>> Regards >> >>> >> >>>> >> >>> >> >>>> Bob. >> >>> >> >>>> >> >>> >> >>>> >> >>> >> >>>> 2009/6/17 Bob Tarling <[email protected]>: >> >>> >> >>>> > I haven't yet analysed if detect 5811 is valid but if so it >> >>> >> >>>> > seems >> >>> >> to >> >>> >> >>>> > me that the new sequence diagrams will be unusable. >> >>> >> >>>> > >> >>> >> >>>> > If this is the case should we consider a patch release? >> >>> >> >>>> > >> >>> >> >>>> > As the sequence diagrams are now a module it would be easy >> >>> >> >>>> > to >> >>> >> release >> >>> >> >>>> > just that one component. >> >>> >> >>>> > >> >>> >> >>>> > Regards >> >>> >> >>>> > >> >>> >> >>>> > Bob. >> >>> >> >>>> > >> >>> >> >>>> >> >>> >> >>>> ------------------------------------------------------ >> >>> >> >>>> >> >>> >> >>>> >> >>> >> >> >>> >> >> >>> >> http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2363011 >> >>> >> >>>> >> >>> >> >>>> To unsubscribe from this discussion, e-mail: >> >>> >> >>>> [[email protected]]. >> >>> >> >>>> To be allowed to post to the list contact the mailing list >> >>> >> >>>> moderator, >> >>> >> >>>> email: [[email protected]] >> >>> >> >>> >> >>> >> >>> >> >>> >> >> >> >>> >> > >> >>> >> >> >>> >> ------------------------------------------------------ >> >>> >> >> >>> >> >> >>> >> http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2365184 >> >>> >> >> >>> >> To unsubscribe from this discussion, e-mail: >> >>> >> [[email protected]]. >> >>> >> To be allowed to post to the list contact the mailing list >> >>> >> moderator, >> >>> >> email: [[email protected]] >> >>> > >> >>> > -- >> >>> > GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT! >> >>> > Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01 >> >>> > >> >>> > ------------------------------------------------------ >> >>> > >> >>> > >> >>> > http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2365628 >> >>> > >> >>> > To unsubscribe from this discussion, e-mail: >> >>> > [[email protected]]. >> >>> > To be allowed to post to the list contact the mailing list >> >>> > moderator, >> >>> > email: [[email protected]] >> >>> > >> >>> >> >>> ------------------------------------------------------ >> >>> >> >>> >> >>> http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2365629 >> >>> >> >>> To unsubscribe from this discussion, e-mail: >> >>> [[email protected]]. >> >>> To be allowed to post to the list contact the mailing list moderator, >> >>> email: [[email protected]] >> >> >> > >> > >> >> ------------------------------------------------------ >> >> http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2366097 >> >> To unsubscribe from this discussion, e-mail: >> [[email protected]]. >> To be allowed to post to the list contact the mailing list moderator, >> email: [[email protected]] > > ------------------------------------------------------ http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2368527 To unsubscribe from this discussion, e-mail: [[email protected]]. To be allowed to post to the list contact the mailing list moderator, email: [[email protected]]
