I did the simple fix for now as I didn't want to see the defect release delayed further.
It would be good if someone familiar with profiles could look at my previous email and Toms code comments once we have the merge complete. Regards Bob On 27 April 2010 12:00, Bob Tarling <[email protected]> wrote: > It looks like this error may depend on the logging level > > The exception I see comes from this debug line which is trying to call > toString of UserDefinedProfile (see the logging statement below) > > static void removeAllProfiles() { > if (manager != null) { > Profile[] profiles = manager.getRegisteredProfiles().toArray( > new Profile[0]); > for (Profile p : profiles) { > try { > manager.removeProfile(p); > } catch (InvalidElementException e) { > LOG.debug("Attempted to delete extent twice in > removeAllProfiles " + p); > } > } > } > } > > So the simple fix is to change that log so that it doesn't mention the > profile name (that works for me locally). > > However maybe we could leave that in place and do some more improvements. > > I spotted some comments from Tom in UserDefinedProfile.getDisplayName() > UserDefinedProfile.toString() just delegates to > UserDefinedProfile.getDisplayName() which I have pasted below > > public String getDisplayName() { > // TODO: Seems like overkill to load the model just to get the display > // name, but that's where it's stored currently - tfm > loadModel(); > return displayName; > } > > Can this be resolved as its actually the loadModel call that causes > the problem. At the very least could we call loadModel only if > displayName is null. > > That does not seem possible at the moment as displayName actually > appears to have two different values at different times (not wise). In > the constructor UserDefinedProfile(File file, ProfileManager manager) > it can be set to the filename instead of a display name. > > Regards > > Bob > > > > > On 26 April 2010 21:53, Luis Sergio Oliveira <[email protected]> wrote: >> Bob Tarling wrote: >>> Does anyone have a handle on the failing test in TestProjectWithProfiles? >>> >> Not me, I'm currently looking at issue 6038. >> >> Luis >>> Bob >>> >>> On 25 April 2010 21:28, Linus Tolke Tigris <[email protected]> wrote: >>> >>>> I get the same problem when running the tests, updating, and running the >>>> tests again on my development host so this is an ant problem and not a >>>> Hudson problem. The nightly build and the continuous build uses ant and the >>>> build.xml files for ant to compile and run tests. >>>> To fix this on my host I have to run ./build.sh clean. On the Hudson server >>>> I will will reset the workspace for the java5 job. I have done that now. >>>> In this, there is a slight difference between the java5 and the java6 >>>> build in how the Hudson jobs are set up. The java6 build is configured to >>>> start from a freshly checked out copy and you can notice that this problem >>>> does not appear for java6. >>>> /Linus >>>> >>>> On Sun, Apr 25, 2010 at 4:08 PM, Bob Tarling <[email protected]> wrote: >>>> >>>>> Hudson is reporting a failing profile test. >>>>> >>>>> Is this test still relevant and being worked on. >>>>> >>>>> I notice also that Java 5 is trying to run a test that has been >>>>> deleted from SVN - >>>>> >>>>> org.argouml.uml.ui.foundation.core.TestActionAddEnumerationLiteral.testHasIcon >>>>> >>>>> Is Hudson having some problems in building and picking up changes? Is >>>>> that also the cause of the profile failure? >>>>> >>>>> Bob >>>>> >>>>> >> >> ------------------------------------------------------ >> http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2596247 >> >> To unsubscribe from this discussion, e-mail: >> [[email protected]]. >> To be allowed to post to the list contact the mailing list moderator, email: >> [[email protected]] >> > ------------------------------------------------------ http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2596849 To unsubscribe from this discussion, e-mail: [[email protected]]. To be allowed to post to the list contact the mailing list moderator, email: [[email protected]]
