I am not so much lazy as have no idea how to write critics. Actually maybe I am too lazy to find out how :-)
I'll create an issue for creating the critic and remove the faliing test. Cheers Bob On 19 May 2010 15:43, Tom Morris <[email protected]> wrote: > On Wed, May 19, 2010 at 3:27 AM, Bob Tarling <[email protected]> wrote: >> Does anyone have any problem with my change in issue 6088 (rev 18399) >> to disable enforcement of WFR UML 1.4 section 2.10.3.4 #3 >> >> The WFR is described as this >> >> // Collaboration WFR UML 1.4 section 2.10.3.4 #3 >> // [3] If a ClassifierRole or an AssociationRole does not have a name, >> // then it should be the only one with a particular base. >> // [...] >> // and >> // (p.oclIsKindOf (AssociationRole) implies >> // p.name = '' implies >> // self.allContents->forAll ( q | >> // q.oclIsKindOf(AssociationRole) implies >> // (p.oclAsType(AssociationRole).base = >> // q.oclAsType(AssociationRole).base implies >> // p = q) ) ) >> // ) >> >> The result of this is that it is not possible to drag a second class >> (that creates an unnamed classifier role) onto the diagram as both >> those classifier roles would have the same base class. >> >> More typically for naming we tend to use critics as we have no way >> of.later stopping the user from changing the name to empty and >> breaking this rule once again. > > There's a TODO associated with that code which explicitly says that > it's a candidate to move to a critic, so I think making that move is > fine. I was probably just too lazy to go to the trouble of creating a > brand new critic. > > Tom > > ------------------------------------------------------ > http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2610862 > > To unsubscribe from this discussion, e-mail: > [[email protected]]. > To be allowed to post to the list contact the mailing list moderator, email: > [[email protected]] > ------------------------------------------------------ http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2610880 To unsubscribe from this discussion, e-mail: [[email protected]]. To be allowed to post to the list contact the mailing list moderator, email: [[email protected]]
