Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/31#discussion_r90780128
  
    --- Diff: tests/storage/test_models.py ---
    @@ -187,111 +99,18 @@ def test_deployment_update_step_model():
     
         assert remove_rel < remove_node < add_node < add_rel
         assert not add_node < None
    -    # TODO fix logic here so that pylint is happy
    -    # assert not modify_node < modify_rel and not modify_rel < modify_node
    -
    -
    -def _relationship(id=''):
    -    return Relationship(
    -        id='rel{0}'.format(id),
    -        target_id='target{0}'.format(id),
    -        source_id='source{0}'.format(id),
    -        source_interfaces={},
    -        source_operations={},
    -        target_interfaces={},
    -        target_operations={},
    -        type='type{0}'.format(id),
    -        type_hierarchy=[],
    -        properties={})
    -
    -
    -def test_relationships():
    -    relationships = [_relationship(index) for index in xrange(3)]
    -
    -    node = Node(
    -        blueprint_id='blueprint_id',
    -        type='type',
    -        type_hierarchy=None,
    -        number_of_instances=1,
    -        planned_number_of_instances=1,
    -        deploy_number_of_instances=1,
    -        properties={},
    -        operations={},
    -        relationships=relationships,
    -        min_number_of_instances=1,
    -        max_number_of_instances=1)
    -
    -    for index in xrange(3):
    -        assert relationships[index] is \
    -               
next(node.relationships_by_target('target{0}'.format(index)))
    -
    -    relationship = _relationship()
    -
    -    node = Node(
    --- End diff --
    
    test every model and every field in every model


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to