Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/42#discussion_r94770242
--- Diff: tests/storage/test_models.py ---
@@ -664,6 +664,72 @@ def test_node_instance_model_creation(self,
node_storage, is_valid, name, runtim
assert node_instance.deployment ==
node_storage.deployment.list()[0]
+class TestNodeInstanceIP(object):
+
+ ip = '1.1.1.1'
+
+ def test_ip_on_none_hosted_node_instance(self, deployment_storage):
--- End diff --
I'd also add a test where the instance in question is not a host but the
host does have IP (say as runtime property) and verify the IP is returned.
technically speaking its the same code path as
"test_runtime_property_ip_on_hosted_node_instance", but it's a common use case
and we should verify it as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
