[
https://issues.apache.org/jira/browse/ARIA-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801437#comment-15801437
]
ASF GitHub Bot commented on ARIA-55:
------------------------------------
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/40#discussion_r94771879
--- Diff: aria/orchestrator/workflows/core/events_handler.py ---
@@ -43,18 +43,25 @@ def _task_started(task, *args, **kwargs):
@events.on_failure_task_signal.connect
-def _task_failed(task, *args, **kwargs):
+def _task_failed(task, exception, *args, **kwargs):
with task._update():
- should_retry = (
- (task.retry_count < task.max_attempts - 1 or
- task.max_attempts == task.INFINITE_RETRIES) and
- # ignore_failure check here means the task will not be retries
and it will be marked as
- # failed. The engine will also look at ignore_failure so it
won't fail the workflow.
- not task.ignore_failure)
+ should_retry = all([
+ not isinstance(exception, exceptions.TaskAbortException),
+ task.retry_count < task.max_attempts - 1 or task.max_attempts
== task.INFINITE_RETRIES,
+ # ignore_failure check here means the task will not be retries
and it will be marked
+ # as failed. The engine will also look at ignore_failure so it
won't fail the
+ # workflow.
+ not task.ignore_failure
+ ])
if should_retry:
+ retry_interval = None
--- End diff --
maybe if this is already initialized to something then it should be the
default value or any numeric value rather than None?
> API for task retry and task abort
> ---------------------------------
>
> Key: ARIA-55
> URL: https://issues.apache.org/jira/browse/ARIA-55
> Project: AriaTosca
> Issue Type: Story
> Reporter: Ran Ziv
> Assignee: Dan Kilman
>
> Add an API for aborting a running task, or setting it for a retry after a
> given amount of time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
