[ 
https://issues.apache.org/jira/browse/ARIA-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856157#comment-15856157
 ] 

ASF GitHub Bot commented on ARIA-99:
------------------------------------

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/67#discussion_r99840345
  
    --- Diff: tests/complete/test_parser.py ---
    @@ -0,0 +1,40 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    --- End diff --
    
    Actually, I'm not sure these tests should have moved out from where they 
were at.
    "Complete" means end to end tests; While these are not unit tests per se, 
they are parser specific.
    We already have many tests which aren't standard unit tests yet are treated 
as such. See execution plugin tests for example - those actually run the 
workflow engine.
    On the other hand, the parser might indeed be used regardless of other 
components of ARIA by other projects, and so it might be ok to leave this here.
    Again, I'll leave it for your consideration.


> Straightforward end-to-end tests for parser and built-in workflow
> -----------------------------------------------------------------
>
>                 Key: ARIA-99
>                 URL: https://issues.apache.org/jira/browse/ARIA-99
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Tal Liron
>            Assignee: Tal Liron
>            Priority: Minor
>
> The idea is to start with a comprehensive blueprint and end up with valid 
> results. Essentially all mechanisms in ARIA will be tested except for the 
> actual CLI package -- the tests will simulate what happens when a user enters 
> a CLI command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to