[ 
https://issues.apache.org/jira/browse/ARIA-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876218#comment-15876218
 ] 

ASF GitHub Bot commented on ARIA-106:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/69#discussion_r102234412
  
    --- Diff: aria/logger.py ---
    @@ -135,5 +142,37 @@ def create_file_log_handler(
         return rotating_file
     
     
    +class _SQLAlchemyHandler(logging.Handler):
    +
    +    def __init__(self, session, engine, **kwargs):
    +        logging.Handler.__init__(self, **kwargs)
    +        self._session = session
    +        self._engine = engine
    +
    +        # Cyclic dependency
    +        from aria.storage.modeling.model import Log
    +        self._cls = Log
    +
    +    def emit(self, record):
    +        # pylint fails to recognize that this class does indeed have 
__table__
    +        self._cls.__table__.create(bind=self._engine, checkfirst=True)     
                         # pylint: disable=no-member
    --- End diff --
    
    move no-member to rules (for code and tests).
    
    Check if indeed recreation is necessary 


> Create sqla logging handler
> ---------------------------
>
>                 Key: ARIA-106
>                 URL: https://issues.apache.org/jira/browse/ARIA-106
>             Project: AriaTosca
>          Issue Type: Sub-task
>    Affects Versions: 0.1.0
>            Reporter: Maxim Orlov
>            Assignee: Maxim Orlov
>
> Create an sql based logging mechanism for operations and workflows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to