[ 
https://issues.apache.org/jira/browse/ARIA-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932891#comment-15932891
 ] 

ASF GitHub Bot commented on ARIA-105:
-------------------------------------

Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/72#discussion_r106939485
  
    --- Diff: tests/modeling/test_models.py ---
    @@ -173,92 +168,83 @@ def _test_model(is_valid, storage, model_cls, 
model_kwargs):
             getattr(storage, model_cls.__modelname__).put(model)
             return model
         else:
    -        with pytest.raises((exceptions.StorageError, TypeError),):
    +        with pytest.raises((ValueFormatException, StorageError, 
TypeError),):
                 getattr(storage, 
model_cls.__modelname__).put(model_cls(**model_kwargs))
     
     
     class TestServiceTemplate(object):
     
         @pytest.mark.parametrize(
    -        'is_valid, plan, description, created_at, updated_at, 
main_file_name',
    +        'is_valid, description, created_at, updated_at, main_file_name',
             [
    -            (False, None, 'description', now, now, '/path'),
    -            (False, {}, {}, now, now, '/path'),
    -            (False, {}, 'description', 'error', now, '/path'),
    -            (False, {}, 'description', now, 'error', '/path'),
    -            (False, {}, 'description', now, now, {}),
    -            (True, {}, 'description', now, now, '/path'),
    +            (True, 'description', now, now, '/path'),
    --- End diff --
    
    Fixed


> Integrate new models into parser
> --------------------------------
>
>                 Key: ARIA-105
>                 URL: https://issues.apache.org/jira/browse/ARIA-105
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to