[ 
https://issues.apache.org/jira/browse/ARIA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943196#comment-15943196
 ] 

ASF GitHub Bot commented on ARIA-126:
-------------------------------------

Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/83#discussion_r108059849
  
    --- Diff: aria/orchestrator/workflows/core/events_handler.py ---
    @@ -73,6 +82,10 @@ def _task_succeeded(task, *args, **kwargs):
             task.ended_at = datetime.utcnow()
             task.status = task.SUCCESS
     
    +        # update node state if necessary
    +        if type(task) is OperationTask and type(task.context) is 
NodeOperationContext:
    --- End diff --
    
    remove the 'ifs'. call the function `update node state of necessary.


> Update state of nodes during normative lifecycle execution
> ----------------------------------------------------------
>
>                 Key: ARIA-126
>                 URL: https://issues.apache.org/jira/browse/ARIA-126
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Avia Efrat
>            Assignee: Avia Efrat
>
> Update a node's state while preforming tasks that reflect changes to its 
> state.
> Currently, this will be hardcoded specifically for lifecycle operations, i.e. 
> `created`, `configured`, `started` etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to