[
https://issues.apache.org/jira/browse/ARIA-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943335#comment-15943335
]
ASF GitHub Bot commented on ARIA-120:
-------------------------------------
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/77#discussion_r108060335
--- Diff: aria/orchestrator/workflows/builtin/utils.py ---
@@ -31,24 +32,59 @@ def create_node_task(interface_name, operation_name,
node):
return None
-def create_relationship_tasks(interface_name, operation_name, runs_on,
node):
+def create_relationships_tasks(
+ node, interface_name, source_operation_name=None,
target_operation_name=None):
"""
- Returns a list of operation tasks for each outbound relationship of
the node if the operation
- exists there.
+ Creates a relationship task (source and target) for all of a
node_instance relationships.
+ :param basestring source_operation_name: the relationship operation
name.
+ :param source_operation_name:
+ :param target_operation_name:
+ :param NodeInstance node: the source_node
+ :return:
"""
+ relationships_groups = groupby(node.outbound_relationships,
+ key=lambda relationship:
relationship.target_node.id)
--- End diff --
groupby is meaningless
> Builtin workflows have wrong execution order in relationship operations
> -----------------------------------------------------------------------
>
> Key: ARIA-120
> URL: https://issues.apache.org/jira/browse/ARIA-120
> Project: AriaTosca
> Issue Type: Bug
> Reporter: Maxim Orlov
>
> The execution order of relationships based operations of a node is wrong.
> In the current state, all of the pre_configure source operations are executed
> before any pre_configure target operations are executed.
> In the desired state, each source-target operations of a single relationship
> are executed side by side (concurrently), and only once both are done, the
> execution of the next relationship's source-target operations commences.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
